Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VFab): change type for location prop #19949

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

SonTT19
Copy link
Contributor

@SonTT19 SonTT19 commented Jun 5, 2024

Description

fixes #19944

Markup:

<template>
  <v-card class="mx-auto" max-width="360">
    <v-layout>
      <v-app-bar absolute extended>
        <v-app-bar-nav-icon />

        <template #extension>
          <v-fab
            :active="!hidden"
            class="ms-4"
            icon="mdi-plus"
            location="bottom start"
            size="small"
            absolute
            offset
          />
        </template>
      </v-app-bar>

      <v-main>
        <v-sheet class="pa-4 text-center" color="surface-light" height="300">
          <v-btn
            :text="hidden ? 'Show' : 'Hide'"
            color="surface-variant"
            width="80"
            @click="hidden = !hidden"
          />
        </v-sheet>

        <v-sheet height="125">
          <v-fab
            :active="!hidden"
            class="me-4"
            icon="mdi-plus"
            location="top end"
            absolute
            offset
          />
        </v-sheet>
      </v-main>
    </v-layout>
  </v-card>
</template>

<script setup lang="ts">
  import { ref } from 'vue'
  const hidden = ref(false)
</script>

@johnleider johnleider added this to the v3.6.x milestone Jun 11, 2024
@johnleider johnleider added T: bug Functionality that does not work as intended/expected C: VFab labels Jun 11, 2024
@johnleider johnleider merged commit 07a6fb8 into master Jun 11, 2024
19 checks passed
@johnleider johnleider deleted the fix/19944-v-fab-location-props branch June 11, 2024 17:40
@MatthewAry MatthewAry added the S: has PR The issue has a pending Pull Request label Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: VFab S: has PR The issue has a pending Pull Request T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report][3.6.8] v-fab location wrong typescript definition
3 participants